ferruzzi commented on code in PR #36803:
URL: https://github.com/apache/airflow/pull/36803#discussion_r1462362234


##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -721,6 +721,7 @@ def _process_executor_events(self, session: Session) -> int:
             if state == TaskInstanceState.QUEUED:
                 ti.external_executor_id = info
                 self.log.info("Setting external_id for %s to %s", ti, info)
+                session.commit()

Review Comment:
   A valid point, and I don't know the right answer.   I'll see what others 
think.  It may be safest to move it outside the loop



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to