potiuk commented on PR #34311: URL: https://github.com/apache/airflow/pull/34311#issuecomment-1904815551
> @potiuk @hussein-awala @styannik apologies for being out of the loop here. Been a bit swamped on my end :). Welcome back :). > I think there should be a slightly larger conversation about what we do/return when we run dag.test. Yep. I think we should document design decisions for it and provide some best practices on what is expected of this command and how to use it. The current description https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/executor/debug.html#testing-dags-with-dag-test is rather rudimentary and does not explain what happens and what to expect I think there are two things that maybe need clarification/explanation that I saw people asked (and maybe making decisions): * what happens with DB entries - dag run, task instances, xcoms? Are there left overs after running dags test? Should they be cleared (autoamtically with a flag ? manually?) * what is the return value and exit codse (if used in CLI) f the test method (that's what you asked for. Yeah - dictionary is good for test() python method, but the `airflow dags test` CLI (that uses `dag.test()` method intrnally and it should derive exit code from the state of dag run, and possibly have a way to save the dictionary as output somewhere (or print at stdout). I think the last one is important for automation in CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
