This is an automated email from the ASF dual-hosted git repository.

husseinawala pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new d78a114aa0 Increase tenacity wait in read_pod_logs (#36955)
d78a114aa0 is described below

commit d78a114aa05bee0e02a09a43056827a03180844a
Author: Niko Oliveira <[email protected]>
AuthorDate: Mon Jan 22 16:01:26 2024 -0800

    Increase tenacity wait in read_pod_logs (#36955)
    
    We're still seeing issues in kubernetes based system tests.
    
    See context and discussions here: 
https://github.com/apache/airflow/pull/35504
---
 airflow/providers/cncf/kubernetes/utils/pod_manager.py    | 2 +-
 tests/providers/cncf/kubernetes/utils/test_pod_manager.py | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/airflow/providers/cncf/kubernetes/utils/pod_manager.py 
b/airflow/providers/cncf/kubernetes/utils/pod_manager.py
index 0e736daa6a..281c82884a 100644
--- a/airflow/providers/cncf/kubernetes/utils/pod_manager.py
+++ b/airflow/providers/cncf/kubernetes/utils/pod_manager.py
@@ -634,7 +634,7 @@ class PodManager(LoggingMixin):
         remote_pod = self.read_pod(pod)
         return container_is_terminated(pod=remote_pod, 
container_name=container_name)
 
-    @tenacity.retry(stop=tenacity.stop_after_attempt(3), 
wait=tenacity.wait_exponential(), reraise=True)
+    @tenacity.retry(stop=tenacity.stop_after_attempt(6), 
wait=tenacity.wait_exponential(max=15), reraise=True)
     def read_pod_logs(
         self,
         pod: V1Pod,
diff --git a/tests/providers/cncf/kubernetes/utils/test_pod_manager.py 
b/tests/providers/cncf/kubernetes/utils/test_pod_manager.py
index fc09d6bb02..0300cd0639 100644
--- a/tests/providers/cncf/kubernetes/utils/test_pod_manager.py
+++ b/tests/providers/cncf/kubernetes/utils/test_pod_manager.py
@@ -100,6 +100,9 @@ class TestPodManager:
             BaseHTTPError("Boom"),
             BaseHTTPError("Boom"),
             BaseHTTPError("Boom"),
+            BaseHTTPError("Boom"),
+            BaseHTTPError("Boom"),
+            BaseHTTPError("Boom"),
         ]
         with pytest.raises(BaseHTTPError):
             self.pod_manager.read_pod_logs(pod=mock.sentinel, 
container_name="base")

Reply via email to