This is an automated email from the ASF dual-hosted git repository.
jedcunningham pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 1c958a2ffa Chart: Add warning about changing/adding metrics mappings
(#36960)
1c958a2ffa is described below
commit 1c958a2ffa52bb13f82452c66a3f94cc6cd0aa44
Author: Jed Cunningham <[email protected]>
AuthorDate: Mon Jan 22 17:47:29 2024 -0700
Chart: Add warning about changing/adding metrics mappings (#36960)
We might still miss some, but this is better than nothing?
---
chart/files/statsd-mappings.yml | 6 ++++++
chart/templates/configmaps/statsd-configmap.yaml | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/chart/files/statsd-mappings.yml b/chart/files/statsd-mappings.yml
index f5339efd6c..da166f0729 100644
--- a/chart/files/statsd-mappings.yml
+++ b/chart/files/statsd-mappings.yml
@@ -15,6 +15,12 @@
# specific language governing permissions and limitations
# under the License.
---
+# {{/*
+# WARNING: Be aware that most changes to these mappings will break backwards
compatibility!
+# E.g. moving to labels will break existing dashboards.
+# instead utilize `statsd.overrideMappings` in your environment, until we have
version 2
+# of the helm chart.
+# */}}
mappings:
# Map dot separated stats to labels
- match: airflow.dagrun.dependency-check.*.*
diff --git a/chart/templates/configmaps/statsd-configmap.yaml
b/chart/templates/configmaps/statsd-configmap.yaml
index c195109673..0529e16082 100644
--- a/chart/templates/configmaps/statsd-configmap.yaml
+++ b/chart/templates/configmaps/statsd-configmap.yaml
@@ -44,7 +44,7 @@ data:
mappings:
{{- toYaml .Values.statsd.overrideMappings | nindent 6 }}
{{- else }}
- {{- .Files.Get "files/statsd-mappings.yml" | nindent 4 }}
+ {{- tpl (.Files.Get "files/statsd-mappings.yml") . | nindent 4 }}
{{- if .Values.statsd.extraMappings }}
{{- toYaml .Values.statsd.extraMappings | nindent 6 }}
{{- end }}
