pankajastro commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1463026613
##########
airflow/providers/google/common/hooks/base_google.py:
##########
@@ -639,6 +689,7 @@ async def get_sync_hook(self) -> Any:
self._sync_hook = await
sync_to_async(self.sync_hook_class)(**self._hook_kwargs)
return self._sync_hook
- async def service_file_as_context(self) -> Any:
Review Comment:
I'll call it a breaking change. We will have to either restore this method
and add a deprecation for future removal or this PR can go in a major release
so need to update the changelog accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
