potiuk commented on PR #36755:
URL: https://github.com/apache/airflow/pull/36755#issuecomment-1907128698
There are few more interesting failures:
* we have a few tests that were not testing the right things. They were
calling `assert mock.called_once()` or `assert mock.called_with()` which was
wrong - because those are attributes not methods -> should be
`mock.assert_called_once_with()` - we need to fix those (and at least one of
the tests for celery_executor is not called, so we need to check more closely -
maybe those will uncover real bugs.
* apparently some mysql tests fail claiming that pickled data is too big to
store in the DB - which I guess might be attributed to much more complex
bytecode (with specialized interpreters and other speed improvements). But we
need to look in more detail
* Unfortunately looks that we are held by `universal_pathlib` and object
storage / io.
We have
```
____________________ ERROR collecting tests/io/test_path.py
____________________
ImportError while importing test module '/opt/airflow/tests/io/test_path.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.12/importlib/__init__.py:90: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/io/test_path.py:31: in <module>
from airflow.io.path import ObjectStoragePath
airflow/io/path.py:29: in <module>
from upath.implementations.cloud import CloudPath, _CloudAccessor
/usr/local/lib/python3.12/site-packages/upath/__init__.py:2: in <module>
from upath.core import UPath
/usr/local/lib/python3.12/site-packages/upath/core.py:8: in <module>
from pathlib import _PosixFlavour # type: ignore
E ImportError: cannot import name '_PosixFlavour' from 'pathlib'
(/usr/local/lib/python3.12/pathlib.py)
----------- generated xml file: /files/test_result-other-sqlite.xml
------------
````
And the reason is that universal_pathlib does not support Python 3.12 yet.
The issue is here https://github.com/fsspec/universal_pathlib/issues/137
(and fix seems to be coming as flavours are retrieved differently now in
https://github.com/fsspec/universal_pathlib/pull/152 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
