ferruzzi commented on PR #36962: URL: https://github.com/apache/airflow/pull/36962#issuecomment-1908616937
@dirrao I didn't add any test cases because it's just reformatting a string. Could you suggest a test case you'd like to see? I thought of two: one with a single-line query and one with a multi-line query which each assert the expected number of newlines in the log message, but that seems overly complicated for what it is... I think it would be something like "capture all logs, for each captured log message, if it contains 'Running Query with params' then assert it has the expected number of line breaks"... It seems maybe excessive but I can add it if you think it's important. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
