dirrao commented on code in PR #36968:
URL: https://github.com/apache/airflow/pull/36968#discussion_r1465798357
##########
airflow/sentry.py:
##########
@@ -178,8 +179,12 @@ def wrapper(_self, *args, **kwargs):
with sentry_sdk.push_scope():
try:
- # Is a LocalTaskJob get the task instance
- if hasattr(_self, "task_instance"):
+ ti_from_kwargs = kwargs.get("ti", None)
Review Comment:
whyntask instance is mandatory for sentry error logging?
##########
airflow/sentry.py:
##########
@@ -178,8 +179,12 @@ def wrapper(_self, *args, **kwargs):
with sentry_sdk.push_scope():
try:
- # Is a LocalTaskJob get the task instance
- if hasattr(_self, "task_instance"):
+ ti_from_kwargs = kwargs.get("ti", None)
Review Comment:
why task instance is mandatory for sentry error logging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
