potiuk commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1909758045
> I guess this affects only providers which explicitly propagate, something
like super().__init__(logger_name=kwargs.pop("logger_name", None)):
[mongo:
3.6.0rc1](https://pypi.org/project/apache-airflow-providers-mongo/3.6.0rc1)
[segment:
3.5.0rc1](https://pypi.org/project/apache-airflow-providers-segment/3.5.0rc1)
[slack:
8.6.0rc1](https://pypi.org/project/apache-airflow-providers-slack/8.6.0rc1)
[common.sql:
1.11.0rc1](https://pypi.org/project/apache-airflow-providers-common-sql/1.11.0rc1)
Yes. Looks like the #34964 that introduced the logger_name had a hidden
back-compatibility issue and we simply can't pass loggger_name for airflow <
2.8.0 . I guess we should remove these providers and only pass logger_name from
our providers conditionally (and add pre-commit for that).
Smth like:
```python
if
packaging.version.parse(packaging.version.parse(airflow_version).base_version)
< packaging.version.parse(
"2.8.0"
):
super().__init__()
else:
super().__init__(logger_name=kwargs.pop("logger_name", None))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
