potiuk commented on code in PR #36710:
URL: https://github.com/apache/airflow/pull/36710#discussion_r1466590749


##########
airflow/timetables/datasets.py:
##########
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+import collections.abc
+import typing
+
+import attrs
+
+from airflow.datasets import Dataset
+from airflow.exceptions import AirflowTimetableInvalid
+from airflow.timetables.simple import DatasetTriggeredTimetable
+from airflow.utils.types import DagRunType
+
+if typing.TYPE_CHECKING:
+    import pendulum
+
+    from airflow.timetables.base import DagRunInfo, DataInterval, 
TimeRestriction, Timetable
+
+
+class DatasetTimetable(DatasetTriggeredTimetable):

Review Comment:
   I am afraid that  ship has sailed (TimeTable). It's original sin of using 
TimeTable where we have not imagined ther might be other triggers. 
   
   But we could potentially consider making an Alias and rename the base class 
as well - possibly that's worth considering. Unfortunately Trigger has alredy 
been taken for something else (this would be probably best name). 
   
   Maybe just `Schedule` - taking into account that the canonical name of the 
parameter is "schedule' and:
   
   ```
   ScheduleArg = Union[ArgNotSet, ScheduleInterval, Timetable, 
Collection["Dataset"]]
   ```
   
   While schedule is also time-bound, it's far less than TimeTable:
   
   ```python
   DatasetOrTimeSchedule(CustomSchedule):
   ```
   
   That would be nice if we do it this way I think,



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to