jscheffl commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466910031
##########
COMMITTERS.rst:
##########
@@ -15,14 +15,39 @@
specific language governing permissions and limitations
under the License.
+Committers and PMC members
+==========================
+
+This document assumes that you know how Airflow's community work, but you
would like to learn more about the rules by which we add new members.
+
+Before reading this document, you should be familiar with `Contributors' guide
<contributing-docs/README.rst>`__.
+This document assumes that you are a bit familiar how Airflow's community
work, but you would like to learn more
+about the rules by which we add new members.
Review Comment:
Duplicate text, I assume this is a leftover?
```suggestion
Before reading this document, you should be familiar with `Contributors'
guide <contributing-docs/README.rst>`__.
This document assumes that you are a bit familiar how Airflow's community
work, but you would like to learn more
about the rules by which we add new members.
```
##########
generated/PYPI_README.md:
##########
@@ -163,11 +163,20 @@ release provided they have access to the appropriate
platform and tools.
## Contributing
-Want to help build Apache Airflow? Check out our [contributing
documentation](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst).
+Want to help build Apache Airflow? Check out our [contributing
documentation](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst).
Official Docker (container) images for Apache Airflow are described in
[IMAGES.rst](https://github.com/apache/airflow/blob/main/IMAGES.rst).
+## Commit Policy
+
+* Commits need a +1 vote from a committer who is not the author
+* Do not merge a PR that regresses linting or does not pass CI tests (unless
you have good
+ justification that it a transient error or something that is being fixed in
other PR).
+* We do not merge PRs that have unresolved conversation. Note! This is
experimental - to be assessed by the
+ end of January 2024 if we want to continue it.
+* When we do AIP voting, both PMC member's and committer's `+1s` are
considered a binding vote.
Review Comment:
Is AIP policy for voting correct in this section?
##########
RELEASE_NOTES.rst:
##########
@@ -8279,7 +8279,7 @@ Doc only changes
- [AIRFLOW-XXXX] Add Updating.md section for 1.10.9 (#7385)
- [AIRFLOW-XXXX] Remove duplication in BaseOperator docstring (#7321)
- [AIRFLOW-XXXX] Update tests info in CONTRIBUTING.rst (#7466)
-- [AIRFLOW-XXXX] Small BREEZE.rst update (#7487)
+- [AIRFLOW-XXXX] Small README.rst update (#7487)
Review Comment:
Is this change an accident or desired?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
