potiuk commented on code in PR #37010:
URL: https://github.com/apache/airflow/pull/37010#discussion_r1468017952
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -309,16 +309,19 @@ def __init__(
self.labels = labels or {}
self.startup_timeout_seconds = startup_timeout_seconds
self.startup_check_interval_seconds = startup_check_interval_seconds
- self.env_vars = convert_env_vars(env_vars) if env_vars else []
+ env_vars = convert_env_vars(env_vars) if env_vars else []
Review Comment:
Hmmm. Question - will the resulting V1EnvVar and V1Volume - be properly
processed by our JinJa renderer? I think they are not (but mybe I am wrong) ?
If I am right, we can simply remove the env_var and volume_mounts from the
template_fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
