pateash commented on code in PR #36935:
URL: https://github.com/apache/airflow/pull/36935#discussion_r1468545330
##########
airflow/models/dagrun.py:
##########
@@ -498,6 +498,37 @@ def fetch_task_instances(
tis = tis.where(TI.task_id.in_(task_ids))
return session.scalars(tis).all()
+ @internal_api_call
+ def _check_last_N_dagruns_failed(
+ self,
+ dag_id: str,
+ number_of_dag_runs: int,
+ session: Session
+ ):
+ """Check if last N dags failed."""
+ dag_runs = session.query(DagRun).filter(DagRun.dag_id == dag_id) \
+ .order_by(DagRun.execution_date.desc()) \
+ .limit(number_of_dag_runs).all()
+
+ """ Marking dag as paused, if needed"""
+ toBePaused = all(dag_run.state == DagRunState.FAILED for dag_run in
dag_runs)
Review Comment:
We are checking last N dagruns and checking if all the failed,
this will make sure we have the required count.
please highlight if you think otherwise.
##########
airflow/models/dagrun.py:
##########
@@ -498,6 +498,37 @@ def fetch_task_instances(
tis = tis.where(TI.task_id.in_(task_ids))
return session.scalars(tis).all()
+ @internal_api_call
+ def _check_last_N_dagruns_failed(
+ self,
+ dag_id: str,
+ number_of_dag_runs: int,
+ session: Session
+ ):
+ """Check if last N dags failed."""
+ dag_runs = session.query(DagRun).filter(DagRun.dag_id == dag_id) \
+ .order_by(DagRun.execution_date.desc()) \
+ .limit(number_of_dag_runs).all()
+
+ """ Marking dag as paused, if needed"""
+ toBePaused = all(dag_run.state == DagRunState.FAILED for dag_run in
dag_runs)
Review Comment:
We are checking last N dagruns and checking if all the failed,
this will make sure we have the required count.
please highlight if I am missing some edge case here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
