potiuk commented on code in PR #37050: URL: https://github.com/apache/airflow/pull/37050#discussion_r1468820190
########## .pre-commit-config.yaml: ########## @@ -18,7 +18,7 @@ default_stages: [commit, push] default_language_version: python: python3 - node: 18.6.0 + node: 21.6.1 Review Comment: I see. Yeah that could be valid concern, I have not realized that aggressive node's policy. But to be perfectly honest - I am not so worried. I think there might (and will be) many other problems if someone wants to use some old centos or other things to develop Airflow. And really, there are very little reasons to do it. I believe `Airflow development environment` can have quite high expectations about what are the dependencies it needs - comparing to "airflow" project. If there will be a few people who cannot develop Airflow on REALLY old OS's, I would rather loose those people if they can't upgrade, rather than drag all the others down as not being able to use some later dependencies (docker/docker-compose etc.). We already have pretty aggressive (both are few months old) settings for those min-development versions and I will keep on updating those two. And If there will be valid cases that we broke too many of those - we can always move back. This is only relevant for `main` version of our repo, and we can very quickly go back with those if we have many people complaining. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
