Taragolis commented on code in PR #37060: URL: https://github.com/apache/airflow/pull/37060#discussion_r1470955111
########## airflow/providers/amazon/provider.yaml: ########## @@ -118,10 +118,7 @@ additional-extras: devel-dependencies: - aiobotocore>=2.7.0 - aws_xray_sdk>=2.12.0 - # Moto 5 replaced all decorators with single mock_aws decorator and we need to - # Replace the usage of mock decorators in our tests to be able to use moto 5 - # See https://github.com/apache/airflow/issues/37053 - - moto[cloudformation,glue]>=4.2.12,<5.0.0 + - moto[cloudformation,glue]>=5.0.0 Review Comment: I think that technically it is possible to make it work with both version for make it possible it required to create a workaround function/decorator/context manager which return appropriate decorator/context manager based on the version of `moto`, however due to the fact that this is devel only dependency and affect only tests so maybe it not worthwhile to spend time to create this workaround and just bump to v5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
