[
https://issues.apache.org/jira/browse/AIRFLOW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913505#comment-16913505
]
ASF GitHub Bot commented on AIRFLOW-5285:
-----------------------------------------
potiuk commented on pull request #5884: [AIRFLOW-5285] Pylint pre-commit
filters out pylint_todo files
URL: https://github.com/apache/airflow/pull/5884
We have now all pylint checks incorporated into pre-commit hooks including
filtering out the files from todo list. Also all checks are now moved to a
single job in Travis, utilising multiple processors so it should be even faster
and less overhead to run all the tests.
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5285
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Pre-commit pylint runs over todo files
> --------------------------------------
>
> Key: AIRFLOW-5285
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5285
> Project: Apache Airflow
> Issue Type: Bug
> Components: PR tool
> Affects Versions: 1.10.5
> Reporter: Tomasz Urbaszek
> Priority: Major
>
> Running:
> {code:java}
> pre-commit run --all-files{code}
> runs pylint over files that should be skipped because they are listed in
> pylint_todo.txt:
> {code:java}
> airflow/utils/operator_helpers.py:1:0: R0401: Cyclic import (airflow.bin.cli
> -> airflow.jobs -> airflow.jobs.scheduler_job ->
> airflow.ti_deps.deps.pool_slots_available_dep -> airflow.models ->
> airflow.models.dag) (cyclic-import)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
