uranusjr commented on code in PR #37101:
URL: https://github.com/apache/airflow/pull/37101#discussion_r1472562902


##########
airflow/models/dag.py:
##########
@@ -585,6 +587,8 @@ def __init__(
         self.timetable: Timetable
         self.schedule_interval: ScheduleInterval
         self.dataset_triggers: DatasetBooleanCondition | None = None
+        if isinstance(schedule, DatasetsExpression):
+            self.schedule = extract_datasets(dataset_expression=schedule)
         if isinstance(schedule, (DatasetAll, DatasetAny)):
             self.dataset_triggers = schedule

Review Comment:
   I wonder if we could unify those three into one base class. This doesn’t 
need to be done now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to