potiuk commented on code in PR #36144:
URL: https://github.com/apache/airflow/pull/36144#discussion_r1479623105
##########
airflow/models/dagrun.py:
##########
@@ -272,11 +272,75 @@ def get_state(self):
return self._state
def set_state(self, state: DagRunState) -> None:
+ """Change the state of the DagRan.
Review Comment:
Yep. It looks like it's a good idea to move date modification to `set_state`
as it is the "write" of the state property. @ephraimbuddy - and maybe others
who have a bit more insights and review, but it LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
