Lee-W commented on PR #37176:
URL: https://github.com/apache/airflow/pull/37176#issuecomment-1929335415
> I came up a few questions during implementation
>
> 1. should we use `uri` instead of `dataset_id` in this endpoint? but
we'll have to use Dataset to find its id and then query DDRQ.
>
> 2. What kind of permission would be ideal for this endpoint? or should
we add a new permission for this endpoint?
>
> 3. Should we add the`cutoff_time` in this API? The original thought
was to add more flexibility so that user can delete only the DDRQ created
before this `cutoff_time`
Discussed with @jedcunningham earlier today and make the following changes
according to Jed's suggestion (Thanks Jed!)
1. Change the original endpoint to `DELETE
/dags/{dag_id}/datasets/{uri}/pendingEvents`
2. Add the following endpoints
1. `DELETE /dags/{dag_id}/datasets/pendingEvents`
2. `DELETE /datasets/{uri}/pendingEvents`
3. `GET /dags/{dag_id}/datasets/{uri}/pendingEvents`
4. `GET /dags/{dag_id}/datasets/pendingEvents`
5. `GET /datasets/{uri}/pendingEvents`
3. Rename `cutoff_time` as `before`
4. Change DELETE to use query args provide `before` instead
5. Permission-wise, we can use `requires_access_dag` and
`requires_access_dataset`
For point 5, @vincbeck , we're wondering whether you have any thought on it.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
