potiuk commented on code in PR #37214:
URL: https://github.com/apache/airflow/pull/37214#discussion_r1481653314
##########
airflow/providers/mongo/hooks/mongo.py:
##########
@@ -75,6 +74,10 @@ def __init__(self, mongo_conn_id: str = default_conn_name,
*args, **kwargs) -> N
self.client: MongoClient | None = None
self.uri = self._create_uri()
+ self.allow_insecure = True
Review Comment:
I believe `allow_insecure` only applies when `ssl` is used (plain http is
always insecure). But in fact there were 2 states here:
* http (ssl = False)
* htps + allow_insecure (ssl = True)
What we need is 3 states
* http (ssl = False)
* htps + allow_insecure (ssl = True, allow_insecure=True)
* https - (ssl = True, allow_insecure = False) this should be default when
ssl
So we need separate `allow_insecure` flag with default = False (and this is
breaking change)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
