potiuk commented on PR #37244: URL: https://github.com/apache/airflow/pull/37244#issuecomment-1935951677
If it was a simple breaking change in parameters that users could correct in their DAGs. I'd be for immediate breaking change. But the fact that users might be using an older version of airbyte OSS makes a big difference, because that might require way more effort to upgrade. As I see it - this change is not breaking for DAG Authoring but breaking for - potentially - deployment. Do we know how old version of the OSS Airbyte does not support the new API ? How old it is? Any stats of usage that Airbyte might have? I think we should assess it based on likelihood of breaking multiple users workflows. If the OSS version of Airbyte that is incompatible is like 2 years old, for example, the likelihood is small. Then we could capture the error that happens in this case and explicitly ask users to downgrade. To @Taragolis comment - as long as we raise a very explicitt error and clearly communicate the user "Your Airbyte OSS version does not support the new API this provider supports, please downgrade porovider to version x.y.z" - or something like that - then option 1 is acceptable. But if someone's OSS fresh version installed 4 months ago will stop working then option 2 is better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
