o-nikolas commented on code in PR #37264:
URL: https://github.com/apache/airflow/pull/37264#discussion_r1484718128


##########
airflow/executors/base_executor.py:
##########
@@ -134,6 +135,9 @@ def __repr__(self):
     def start(self):  # pragma: no cover
         """Executors may need to get things started."""
 
+    def check_health(self, verbose: bool = True):

Review Comment:
   Yeah, if we go with option 2, then we keep the method and the contract being 
that it returns whether or not the executor is healthy (bool would work great) 
and then the base executor class persists that in the field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to