JDarDagran commented on code in PR #37255:
URL: https://github.com/apache/airflow/pull/37255#discussion_r1484758073
##########
airflow/providers/openlineage/plugins/adapter.py:
##########
@@ -350,6 +358,7 @@ def _build_run(
@staticmethod
def _build_job(
job_name: str,
+ job_type: JobTypeJobFacet,
Review Comment:
It doesn't need to be a parameter. Can't foresee any scenario in which
OpenLineageAdapter from Airflow OL provider would send any other job type.
In that case it would be simpler just to change `_build_job` method to add
the facet and in `dag_start/failed/success` use the method instead of creating
the `Job` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
