potiuk commented on PR #37322: URL: https://github.com/apache/airflow/pull/37322#issuecomment-1937397915
> @potiuk , Can you please confirm if this check only runs when there is a change in the provider.yaml file? Also it's not the case. In CI we always run "all" pre-commits. Pre-comit has two modes, one local (when it only run pre-commits that are related to locally modified files), and one usually used in ci where `--all-files` switch is used. In CI in case dependencies were modified, we run `--upgrade-to-newer-dependencies`, but even there as of https://github.com/apache/airflow/pull/37305 merged few hours ago, we run `--upgrade-to-newer-dependencies` not when provider.yaml change, but when we detect that the resulting `pyproject.toml` has changed dependencies. And again - this is because running `--upgrade-to-newer-dependencies` with ~700 dependencies takes a lot of time (27 minutes in CI), not only because there is a lot of data, to pull but also because `pip` performs resolution of those dependencies and tries to find the newest versions of those dependencies. So `--upgrade-to-newer-deps` should be the last resort and deliberately run when you really need it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
