Taragolis commented on code in PR #37334:
URL: https://github.com/apache/airflow/pull/37334#discussion_r1485605500


##########
pyproject.toml:
##########
@@ -340,7 +340,6 @@ devel-tests = [
     "coverage>=7.2",
     "pytest-asyncio>=0.23.3",
     "pytest-cov>=4.1.0",
-    "pytest-httpx>=0.21.3",

Review Comment:
   I've just wondering could we replace `httpx` by something else, e.g. 
`requests`. Looks like it uses in just couple places.
   
   Seems like we add this as optional dependency when we can't use `requests` 
due to legal reason:
   - https://github.com/apache/airflow/pull/15781
   - https://github.com/psf/requests/pull/5797
   
   But seems like it resolved now, at least we use `requests` into the 
airflow/api_internal/internal_api_call.py
   
   
https://github.com/apache/airflow/blob/541c9addb6b2ee56244793503cbf5c218e80dec8/airflow/api_internal/internal_api_call.py#L25



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to