Taragolis commented on code in PR #37330: URL: https://github.com/apache/airflow/pull/37330#discussion_r1485688187
########## airflow/providers/qdrant/__init__.py: ########## @@ -14,3 +14,29 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. +# +# NOTE! THIS FILE IS AUTOMATICALLY GENERATED AND WILL BE +# OVERWRITTEN WHEN PREPARING DOCUMENTATION FOR THE PACKAGES. +# +# IF YOU WANT TO MODIFY THIS FILE, YOU SHOULD MODIFY THE TEMPLATE +# `PROVIDER__INIT__PY_TEMPLATE.py.jinja2` IN the `dev/breeze/src/airflow_breeze/templates` DIRECTORY +# +from __future__ import annotations + +import packaging.version + +__all__ = ["__version__"] + +__version__ = "1.0.0" + +try: + from airflow import __version__ as airflow_version +except ImportError: + from airflow.version import version as airflow_version + +if packaging.version.parse(packaging.version.parse(airflow_version).base_version) < packaging.version.parse( Review Comment: > airflow.__version__ is the de-facto standard - many packages are using it. I do not suggest to entirely remove it, at least until Airflow 3, rather than do not use as main way. Good example, hatch do not define in their codebase __version__ in package, some other also force to use importlib instead, because it is not mandatory by any PEPs. > It's simply way, way faster check than using importlib. Internally it doesn't matter where we store/get version until it backward compatible. For third parties importlib potentially should be faster if compare to initialize Airflow settings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
