potiuk commented on PR #37355: URL: https://github.com/apache/airflow/pull/37355#issuecomment-1938577716
To be honest, you are opening hornet's nest with that question. The nicest thing about Black (and ruff-format now) is that we do not have to discuss it and have opinions. It is, what it is. To be a little profane, my friend often said in Polish - "lepiej ch*wo ale jednakowo" - which roughly translates to "even if f*ing bad, it's great it's the same". I really love in black and ruff-format that we do not have to discsuss formatting at all :). So my advice - just make opinionated choices and go for it. If you ask people for opinions about individual choices, it's a lot of time and energy lost for such discussions - there is no way people are going to agree on those and the amount of hostilty created by such discussion is usually disproportionaly huge comparing to benefits/drawbacks they bring. What I do not particularly like about this change is the number of changes it introduces in general. Sounds quite a bit unnecessary, and if I were you, I'd optimise on minimising number of changes it brings rather than asking for opinions of peoplel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
