pankajkoti commented on code in PR #37246: URL: https://github.com/apache/airflow/pull/37246#discussion_r1486120101
########## airflow/providers/common/sql/hooks/sql.py: ########## @@ -37,6 +37,7 @@ import sqlparse from deprecated import deprecated +from more_itertools import chunked Review Comment: Do we need to add `more_itertools` as a dependency for the provider? Upon testing RC Provider [common.sql: 1.11.0rc2](https://pypi.org/project/apache-airflow-providers-common-sql/1.11.0rc2), I am getting the below error ``` Traceback (most recent call last): File "/usr/local/lib/python3.11/site-packages/airflow/providers/common/sql/operators/sql.py", line 28, in <module> from airflow.providers.common.sql.hooks.sql import DbApiHook, fetch_all_handler, return_single_query_results File "/usr/local/lib/python3.11/site-packages/airflow/providers/common/sql/hooks/sql.py", line 40, in <module> from more_itertools import chunked ModuleNotFoundError: No module named 'more_itertools' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
