potiuk commented on code in PR #37360:
URL: https://github.com/apache/airflow/pull/37360#discussion_r1486155187
##########
Dockerfile.ci:
##########
@@ -1158,8 +1141,7 @@ COPY --from=scripts install_pip_version.sh
install_airflow_dependencies_from_bra
# the cache is only used when "upgrade to newer dependencies" is not set to
automatically
# account for removed dependencies (we do not install them in the first place)
RUN bash /scripts/docker/install_pip_version.sh; \
- if [[ ${AIRFLOW_PRE_CACHED_PIP_PACKAGES} == "true" && \
- ${UPGRADE_TO_NEWER_DEPENDENCIES} == "false" ]]; then \
+ if [[ ${AIRFLOW_PRE_CACHED_PIP_PACKAGES} == "true" ]]; then \
Review Comment:
We alwaysh butild the CACHE layer from branch tip - this will not be
invalidated when UPGRADE_TO_NEWER_DEPENDENCIES is set.
##########
Dockerfile.ci:
##########
@@ -1158,8 +1141,7 @@ COPY --from=scripts install_pip_version.sh
install_airflow_dependencies_from_bra
# the cache is only used when "upgrade to newer dependencies" is not set to
automatically
# account for removed dependencies (we do not install them in the first place)
RUN bash /scripts/docker/install_pip_version.sh; \
- if [[ ${AIRFLOW_PRE_CACHED_PIP_PACKAGES} == "true" && \
- ${UPGRADE_TO_NEWER_DEPENDENCIES} == "false" ]]; then \
+ if [[ ${AIRFLOW_PRE_CACHED_PIP_PACKAGES} == "true" ]]; then \
Review Comment:
We alwaysh build the CACHE layer from branch tip - this will not be
invalidated when UPGRADE_TO_NEWER_DEPENDENCIES is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
