potiuk commented on code in PR #37320:
URL: https://github.com/apache/airflow/pull/37320#discussion_r1486656821
##########
tests/core/test_settings.py:
##########
@@ -228,9 +228,11 @@ def
test_uses_updated_session_timeout_config_by_default(self):
("sqlite://", contextlib.nullcontext()),
],
)
-def test_sqlite_relative_path(monkeypatch, value, expectation):
+def test_sqlite_relative_path(value, expectation):
Review Comment:
This monkeypatch was pretty bad when this test runs with others as it had a
lot of side-effects. Settings _AIRFLOW_SKIP_DB_TEST and patching with context
for what's modified in configure_orm made it side-effect free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
