tsgit commented on PR #37356:
URL: https://github.com/apache/airflow/pull/37356#issuecomment-1939475255

   apart from the duplicate ports:  the whitespace changes following that in 
the generated yaml are also odd.
   $ helm template airflow apache-airflow/airflow -f values.yaml 
--namespace=$(NAMESPACE)
   gives 
   ```
       component: webserver
       release: airflow
     ports:
     ports:
     
       -
         name: airflow-ui
         port: 8080
   ```
   
   
   in addition I see a duplicate 
   `cluster-autoscaler.kubernetes.io/safe-to-evict: "true"` in the 
airflow-scheduler deployment section of the rendered chart 
   
   likely due to 
   
   
https://github.com/apache/airflow/blob/main/chart/templates/scheduler/scheduler-deployment.yaml#L98-L106
   
   
   when using the kustomize HelmChartInflationGenerator this results in error
   ```
   error: map[string]interface {}(nil): yaml: unmarshal errors:
     line 47: mapping key "cluster-autoscaler.kubernetes.io/safe-to-evict" 
already defined at line 46
   ```
   
   I believe the worker-deployment template avoids this via
   
https://github.com/apache/airflow/blob/main/chart/templates/workers/worker-deployment.yaml#L41-L42
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to