potiuk commented on code in PR #37401: URL: https://github.com/apache/airflow/pull/37401#discussion_r1488595927
########## dev/breeze/src/airflow_breeze/utils/reproducible.py: ########## Review Comment: yeah, I wanted to fail it in two points: 1) ASAP (at command entry) 2) When the method is used and I forgot to check it ASAP Otherwise when you run `prepare-helm-package` - you will find out about it only about 20 seconds later when helm chart has been prepared. So main check is really 1) and the `repack` check is really 2) - in this case it is of course very fast and unnoticeable, but I wanted to keep it consistent with all the other breeze commands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
