Dikarabo-Molele commented on code in PR #37418:
URL: https://github.com/apache/airflow/pull/37418#discussion_r1489462614


##########
docs/apache-airflow-providers-microsoft-mssql/connections/mssql.rst:
##########
@@ -51,3 +51,15 @@ Extra (optional)
 
     More details on all MSSQL parameters supported can be found in
     `MSSQL documentation 
<https://docs.microsoft.com/en-us/sql/connect/jdbc/setting-the-connection-properties?view=sql-server-ver15>`_.
+
+When specifying the connection as URI (in :envvar:`AIRFLOW_CONN_{CONN_ID}` 
variable) you should specify it
+following the standard syntax of DB connections - where extras are passed as 
parameters
+of the URI. Note that all components of the URI should be URL-encoded.

Review Comment:
   Updated the PR to add the JSON variant and changes are ready to be reviewed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to