mrshu commented on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name URL: https://github.com/apache/airflow/pull/5879#issuecomment-524446941 @ashb I got the tests to pass once `AWS_DEFAULT_REGION` has been exported in proper places. I also added a quick note on this change to the AWS connection docs. Let me try to reiterate once again why do I think this change should be applied: When you install Airflow right now and use either the `AIRFLOW_CONN_` environment variable or the `~/.aws/credentials` to set the AWS connection parameters, the region setting gets ignored and `us-east-1` gets used. The only way of finding that out is diving deep into `botocore` and trying to debug the values it gets passed by Airflow, which is what prompted me to create this Pull Request. Just documenting the fact would be certainly helpful, but I believe this change would be much better: in the case I outlined above you would receive a `NoRegionSet` error which is much more informational than the current state of silently falling back to `us-east-1`. That said, if you do not agree with this change for any reason, I am happy to close this PR and create a new one that would only add the documentation bit. Thanks again!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
