potiuk commented on code in PR #37444:
URL: https://github.com/apache/airflow/pull/37444#discussion_r1491058028
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -406,8 +488,19 @@ def prepare_airflow_packages(
version_suffix_for_pypi=version_suffix_for_pypi,
)
get_console().print("[success]Successfully prepared Airflow packages:")
- for file in sorted(DIST_DIR.glob("apache_airflow*")):
- get_console().print(file.name)
+ packages = tuple(_dist_packages(package_format=package_format,
build_type="airflow"))
+ for dist_info in packages:
+ get_console().print(str(dist_info))
+ get_console().print()
+ if package_format == "wheel":
+ return
+
+ for dist_info in packages:
+ if dist_info.dist_type == "sdist":
+ get_console().print(
+ f"[info]Validate build wheel from sdist distribution:
{dist_info.filepath.name!r}[/]"
+ )
+ _check_sdist_to_wheel(dist_info)
Review Comment:
It's fine - let's keep it. The more guardrails we have while releasing
packages, the better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
