uzhastik commented on code in PR #37458: URL: https://github.com/apache/airflow/pull/37458#discussion_r1492377851
########## airflow/providers/yandex/hooks/http_client.py: ########## @@ -0,0 +1,321 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# This file is a copy of https://github.com/ydb-platform/ydb/tree/284b7efb67edcdade0b12c849b7fad40739ad62b/ydb/core/fq/libs/http_api_client +# It is highly recommended to modify original file first in YDB project and merge it here afterwards Review Comment: I'm not sure the current vendoring workflow is suitable for my situation. I'm the author of these two files, but they are hosted in two places: ydb github repo and airflow github repo. In ydb repo we have integration tests where we ensure protocol between client and YandexQuery (YQ) backend. These tests cannot be moved to airflow repo. So the source of truth is ydb repo. But this client logic is required for airflow operator and there is no pypi package which contains this code. So I decided just to copy it and add some tests with hardcoded YQ backend reponses. I would suggest to fix original code first and then backport it to airflow repo. I can rework these files as if they where created just inside airflow without link to ydb repo, but I wouldn't recommend to maintain them separately from ydb repo. YDB repo has Apache 2 licence, therefore it is safe to copy files from ydb repo completely or partially to another repository. We have amazing plan to improve our YQ backend so that it would pretend to be a YDB cluster. That means that we can use existing YDB python SDK ( https://github.com/ydb-platform/ydb-python-sdk ) to access YQ backend and these two files with http client logic could be removed afterwards. But improving YQ backend is not easy^ we would spent several months to make it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
