Dev-iL commented on code in PR #37545:
URL: https://github.com/apache/airflow/pull/37545#discussion_r1494686253
##########
airflow/settings.py:
##########
@@ -27,7 +27,7 @@
from typing import TYPE_CHECKING, Any, Callable
import pluggy
-from sqlalchemy import create_engine, exc, text
+from sqlalchemy import __version__ as sqlalchemy_version, create_engine, exc,
text
Review Comment:
I originally did this (in a new util file dedicated to dependency version
checks):
```python
from packaging.version import Version, parse as parse_version
from sqlalchemy import __version__ as sqlalchemy_version
def is_sqlalchemy_v1() -> bool:
"""Check if SQLAlchemy v1 is installed."""
installed: Version = parse_version(sqlalchemy_version)
return installed.release[0] == 1
```
But then saw the `PENDULUM3` example and amended my code. I don't changing
it to anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
