pankajkoti commented on code in PR #37546:
URL: https://github.com/apache/airflow/pull/37546#discussion_r1495238025
##########
airflow/providers/cncf/kubernetes/triggers/pod.py:
##########
@@ -254,6 +254,7 @@ async def _wait_for_container_completion(self) ->
TriggerEvent:
"message": "Container state failed",
}
)
+ self.log.info("Container is not completed and still working.")
Review Comment:
yes, I agree. And now that with logging_interval we have the ability to
periodically fetch container logs, this may not be even needed. I am inclined
towards closing this PR. WDYT?
cc: @pankajastro @eladkal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
