uranusjr commented on code in PR #37545:
URL: https://github.com/apache/airflow/pull/37545#discussion_r1495257952
##########
airflow/settings.py:
##########
@@ -107,6 +107,8 @@
"shutdown": "blue",
}
+SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1")
Review Comment:
Since we have `packaging` available and this is a one-time calculation, I’d
try to properly parse the version with `packaging.version.Version` to be the
most technically correct. And maybe read the actual package version with
`importlib.metadata` instead.
But even more ideally, is there a way to actually detect whether the
`encoding` parameter is supported or not? Feature detection is always better
than agent detection if possible (this is borrowed from web frontend but also
applies well here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
