This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git
commit 8295984f042551dfc1d3e2c70b41e0a7b31519d2 Author: jkramer-ginkgo <[email protected]> AuthorDate: Fri Jan 26 16:19:41 2024 -0500 Remove superfluous `@Sentry.enrich_errors` (#37002) * Remove superfluous `@Sentry.enrich_errors` from `TaskInstance._schedule_downstream_tasks` A recent refactoring broke the contract `enrich_errors` expect. This decorator is being removed because it's not desired to log Sentry errors for scheduling issues. * Fix incorrect parameter name Resolves MyPy error (cherry picked from commit 45b6b7a7a3fb0f2599a12d14863ab77e3a2970ef) --- airflow/models/taskinstance.py | 1 - airflow/sentry.py | 3 +-- airflow/serialization/pydantic/taskinstance.py | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/airflow/models/taskinstance.py b/airflow/models/taskinstance.py index dfc1a1d5cf..4976b4919e 100644 --- a/airflow/models/taskinstance.py +++ b/airflow/models/taskinstance.py @@ -3248,7 +3248,6 @@ class TaskInstance(Base, LoggingMixin): @classmethod @internal_api_call - @Sentry.enrich_errors @provide_session def _schedule_downstream_tasks( cls, diff --git a/airflow/sentry.py b/airflow/sentry.py index da46f92478..50f7b019a8 100644 --- a/airflow/sentry.py +++ b/airflow/sentry.py @@ -161,8 +161,7 @@ if conf.getboolean("sentry", "sentry_on", fallback=False): """ Decorate errors. - Wrap TaskInstance._run_raw_task and LocalTaskJob._run_mini_scheduler_on_child_tasks - to support task specific tags and breadcrumbs. + Wrap TaskInstance._run_raw_task to support task specific tags and breadcrumbs. """ session_args_idx = find_session_idx(func) diff --git a/airflow/serialization/pydantic/taskinstance.py b/airflow/serialization/pydantic/taskinstance.py index 72fad7612d..9e874c569b 100644 --- a/airflow/serialization/pydantic/taskinstance.py +++ b/airflow/serialization/pydantic/taskinstance.py @@ -396,7 +396,7 @@ class TaskInstancePydantic(BaseModelPydantic, LoggingMixin): :meta: private """ return TaskInstance._schedule_downstream_tasks( - ti=self, sessions=session, max_tis_per_query=max_tis_per_query + ti=self, session=session, max_tis_per_query=max_tis_per_query ) def command_as_list(
