Taragolis commented on code in PR #37558:
URL: https://github.com/apache/airflow/pull/37558#discussion_r1495716325
##########
tests/always/test_example_dags.py:
##########
@@ -36,6 +44,29 @@
"The test is skipped because we are running in limited Pydantic
environment", allow_module_level=True
)
+# Some certain of examples/system tests might require additional dependencies,
+# which are not installed into specific CI check
+# Format of dictionary:
+# key: prefix of the file which need to be excluded,
+# values: dictionary with package distributions and optional specifier, e.g.
>=2.3.4
+OPTIONAL_PROVIDERS_DEPENDENCIES: dict[str, dict[str, str | None]] = {
+ # Regression of https://github.com/apache/airflow/pull/37524
+ # It loads the module now eagerly instead of lazily
+ "tests/system/providers/common/io/example_file_transfer_local_to_s3.py":
{"s3fs": None}
Review Comment:
I'm think it depend on how does it long takes to fix it.
If we think that it could be fixed soon, than we fix it first and after that
made appropriate changes
If do not know how long does it take we have a to option
Option 1: Revert https://github.com/apache/airflow/pull/37524, otherwise we
would have an error in the other tests
Option 2: Hide issue (merge this PR as is), create a task and remove it
during the fixing
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
