jedcunningham commented on code in PR #37512:
URL: https://github.com/apache/airflow/pull/37512#discussion_r1496560888


##########
airflow/api_connexion/endpoints/dataset_endpoint.py:
##########
@@ -81,7 +84,23 @@ def get_datasets(
 
     total_entries = session.scalars(select(func.count(DatasetModel.id))).one()
     query = select(DatasetModel)
-    if uri_pattern:
+
+    if dag_ids and uri_pattern:

Review Comment:
   This is overly complicated. Just do multiple `filter()`'s, one for the 
uri_pattern if passed and another for the dag_id if passed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to