Taragolis commented on code in PR #37575: URL: https://github.com/apache/airflow/pull/37575#discussion_r1497218249
########## tests/serialization/serializers/test_serializers.py: ########## @@ -26,19 +27,22 @@ import pytest from dateutil.tz import tzutc from deltalake import DeltaTable +from packaging.version import Version from pendulum import DateTime from pendulum.tz.timezone import FixedTimezone, Timezone -from airflow import PY39 from airflow.models.param import Param, ParamsDict from airflow.serialization.serde import DATA, deserialize, serialize -if PY39: +if sys.version_info >= (3, 9): Review Comment: The API of importlib.metadata not fully compatible between provisional (3.8-3.9) an stable (3.10+) I think maybe it should be compatible in versions, since we use it in 3.9 which also provisional. My thoughts that we should use bakported version, just not for thinking about is this functional compatible or not. But since this part about the tests we might use only stdlib version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
