Taragolis commented on code in PR #37465:
URL: https://github.com/apache/airflow/pull/37465#discussion_r1497500920
##########
airflow/datasets/__init__.py:
##########
@@ -46,3 +46,12 @@ def _check_uri(self, attr, uri: str):
def __fspath__(self):
return self.uri
+
+ def __eq__(self, other):
+ if isinstance(other, self.__class__):
+ return self.uri == other.uri
+ else:
+ return NotImplemented
+
+ def __hash__(self):
+ return hash(self.uri)
Review Comment:
Just wondering is also `extra` should be take into the account when
calculate extra? If so it would be prettry difficult because dicts are
unhashable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
