feluelle commented on a change in pull request #5909: [AIRFLOW-4391] Fix
tooltip for None-State Tasks in 'Recent Tasks'
URL: https://github.com/apache/airflow/pull/5909#discussion_r317373836
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -403,7 +403,13 @@ <h2>DAGs</h2>
});
d3.json("{{ url_for('Airflow.task_stats') }}", function(error, json) {
for(var dag_id in json) {
- states = json[dag_id];
+ states = json[dag_id].map(task => {
Review comment:
I thought it might be the better decision to have a None state in js as we
have in Python. But Python None probably should equal Null in JS.
And your change really only changes the displayed value which I think is
probably more appropriate. So I will go for your solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
