dstandish commented on code in PR #37016: URL: https://github.com/apache/airflow/pull/37016#discussion_r1498092252
########## tests/cli/commands/test_dag_command.py: ########## Review Comment: the issue was the test was not good. they were testing that it works with custom table but instead of custom timetable they used a mock object. so when the test actually ran, it was actually using a different non-custom timetable. it was passing by accident. our logic change re parsing of the "schedule" attr changed the behavior and revealed the issue, which we fixed by mocking less invasively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
