hterik commented on issue #37484: URL: https://github.com/apache/airflow/issues/37484#issuecomment-1958850711
Ok, i was not aware how this was used to passed through forks and subprocesses. If it's required and you are sure about where this is called it should be fine. I don't have any better suggestion than global variables for forks and explicitly setting the `env` on `POpen` for `base_task_runner`. I also haven't seen any real-life issues caused by this, it was just a code review observation. On second thought i also think the GIL might reduce those risks in Python, not sure. Feel free to close this if you agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
