sudiptob2 commented on code in PR #37555:
URL: https://github.com/apache/airflow/pull/37555#discussion_r1499941678
##########
airflow/cli/commands/internal_api_command.py:
##########
@@ -240,11 +241,11 @@ def create_app(config=None, testing=False):
with flask_app.app_context():
init_error_handlers(flask_app)
- init_api_internal(flask_app, standalone_api=True)
+ init_api_internal(connexion_app, standalone_api=True)
init_jinja_globals(flask_app)
init_xframe_protection(flask_app)
- return flask_app
+ return connexion_app
Review Comment:
Thanks, got it. here `connexion_app.app` returns a `FlaskApp` so we can
return it. Can you explain or give some reference on the benefits you
anticipate? We do not have the full context of this PR yet. Will help to
understand the migration better 💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]