jedcunningham commented on code in PR #37642:
URL: https://github.com/apache/airflow/pull/37642#discussion_r1500021429
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -451,7 +451,12 @@ def _check_sdist_to_wheel_dists(dists_info:
tuple[DistributionPackageInfo, ...])
)
sys.exit(1)
pip_command = (python_path.__fspath__(), "-m", "pip")
- run_command([*pip_command, "install",
f"pip=={AIRFLOW_PIP_VERSION}"], check=True)
+ result = run_command(
+ [*pip_command, "install", f"pip=={AIRFLOW_PIP_VERSION}"],
check=False, stdout=DEVNULL
Review Comment:
Instead of devnull'ing stdout, can we capture it to show if things do go
wrong? It could be helpful context to supplement stderr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
