jedcunningham commented on code in PR #37641:
URL: https://github.com/apache/airflow/pull/37641#discussion_r1500198885


##########
tests/api_connexion/endpoints/test_event_log_endpoint.py:
##########
@@ -291,6 +291,29 @@ def test_should_filter_eventlogs_by_when(self, 
create_log_model, session):
             assert response.status_code == 200
             assert {eventlog["event"] for eventlog in 
response.json["event_logs"]} == expected_eventlogs
 
+    def test_should_filter_eventlogs_by_included_events(self, 
create_log_model):
+        for event in ["TEST_EVENT_1", "TEST_EVENT_2", "cli_scheduler"]:
+            create_log_model(event=event, when=self.default_time)
+        response = self.client.get(
+            "/api/v1/eventLogs?included_events=TEST_EVENT_1,TEST_EVENT_2",
+            environ_overrides={"REMOTE_USER": "test_granular"},
+        )
+        assert response.status_code == 200
+        response_data = response.json
+        assert len(response_data["event_logs"]) == 2

Review Comment:
   ```suggestion
           assert len(response_data["event_logs"]) == 2
           assert {"TEST_EVENT_1", "TEST_EVENT_2"} == {x["event"] for x in 
response_data["event_logs"]}
   ```
   
   Oops, forgot this one in the last round.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to